-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inner hits support #672
Inner hits support #672
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #672 +/- ##
==========================================
+ Coverage 57.29% 62.66% +5.37%
==========================================
Files 315 376 +61
Lines 9823 11133 +1310
==========================================
+ Hits 5628 6977 +1349
+ Misses 2902 2876 -26
+ Partials 1293 1280 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@MaximMolchanov thanks! amend your commit with |
7c10846
to
29e266f
Compare
Tried to sign and force push with update, pls take a look. Some checks are failed, but I think I've done what I can |
@MaximMolchanov DCO is still failing because all commits have to be signed, not just the last one, so you'd need to re-push all. Squash and force push may be easier. |
But I've resigned all three |
Oh, it's a config problem.
The signature has to match the email of the commit, your local git config is different I think? |
Signed-off-by: Maxim Molchanov <[email protected]>
Signed-off-by: Maxim Molchanov <[email protected]>
Signed-off-by: Maxim Molchanov <[email protected]>
29e266f
to
b30a43b
Compare
Ok, now should work. I think I've resigned them finally :) |
Description
Added inner hits param support